Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: serialize system requirements #2753

Merged
merged 3 commits into from
Dec 20, 2024
Merged

feat: serialize system requirements #2753

merged 3 commits into from
Dec 20, 2024

Conversation

ruben-arts
Copy link
Contributor

This allows us to add it to pixi info which I did:

        Environment: img2txt
           Features: img2txt, img2txt_base
        Solve group: img2txt
           Channels: pytorch, conda-forge, bioconda, anaconda
   Dependency count: 1
       Dependencies: python
  PyPI Dependencies: paddlepaddle, layoutparser, easyocr
   Target platforms: win-64, linux-aarch64, osx-arm64, osx-64, linux-64
System requirements: cuda = "12"
                     libc = "2.27"

Printing only if it is defined by the user

Hofer-Julian
Hofer-Julian requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

crates/pixi_manifest/src/system_requirements.rs Outdated
Comment on lines 533 to 536
assert_eq!(
serialized.replace("\n", "").replace(" ", ""),
expected.replace("\n", "").replace(" ", "")
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use snapshots here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

crates/pixi_manifest/src/system_requirements.rs Outdated
Comment on lines 563 to 566
assert_eq!(
serialized.replace("\n", "").replace(" ", ""),
expected.replace("\n", "").replace(" ", "")
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use shapshots here as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Hofer-Julian Hofer-Julian merged commit 390f35d into prefix-dev:main Dec 20, 2024
28 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 24, 2024
Merged
@ruben-arts ruben-arts mentioned this pull request Jan 2, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruben-arts @Hofer-Julian